-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: feed settings survey #3174
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
I re-triggered the domain assignment, hence mark as draft and back. |
packages/shared/src/styles/custom.ts
Outdated
// this file was created to contain all custom temporary colors (outside the guideline) | ||
// and it is ideal to have this file to contain fewer colors as possible | ||
// we should eventually convert the custom colors to be part of the guideline once it is deemed to be used frequently | ||
|
||
export const feedSurveyBg = | ||
'linear-gradient(180deg, rgba(255, 233, 35, 0.08) 0%, rgba(252, 83, 141, 0.08) 50%, rgba(113, 71, 237, 0.08) 100%)'; | ||
|
||
export const feedSurveyBorder = | ||
'linear-gradient(180deg, rgba(255, 233, 35, 1) 0%, rgba(252, 83, 141, 1) 50%, rgba(113, 71, 237, 1) 100%)'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make it easier to track all custom colors, I created this file and added some notes.
You are maybe looking at tablet mode. |
@idoshamun as we are now almost at the end of this PR. Feel free to review the analytics events for this experiment. |
I forgot which one I was looking at 🙈 |
@sshanzel i surfaced product concern, once it gets resolved i'll review again. Thanks! |
packages/shared/src/lib/analytics.ts
Outdated
@@ -169,6 +170,7 @@ export enum FeedItemTitle { | |||
} | |||
|
|||
export enum TargetType { | |||
PromotionCard = 'promotion_card', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have this field already MarketingCtaCard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I noticed it was available but the name for the enum was quite specific to the case of marketing, so I thought of separating them. Though I can unify them to avoid duplicates by renaming the original one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's better to reuse. They need to match
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated here: 98359be 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from analytics perspective. Thanks for checking!
Changes
feed_settings_feedback
and a boolean value.TODO:
Preview:
Screen.Recording.2024-06-03.at.2.22.42.PM.mov
Events
Did you introduce any new tracking events?
Don't forget to update the Analytics Taxonomy sheet
Log the new/changed events below:
Please make sure existing components are not breaking/affected by this PR
Manual Testing
On those affected packages:
Did you test the modified components media queries?
Did you test on actual mobile devices?
MI-355 #done
Preview domain
https://mi-355.preview.app.daily.dev